PiCamera Project not working

Question

I'm a total newbie taking a coding class in High School. I have been trying to get a portable PiCamera up and running, but I have encountered some bugs, that I do not know how to fix. Here is the code:

from gpiozero import Buttonfrom gpiozero import Button
from gpiozero import LED
from picamera import PiCamera
from datetime import datetime
from time import sleep


right_button = Button(17) #GPIO17 --- pin 11
light = LED(23) #GPIO14 --- pin 16

camera = PiCamera()
light.on()


def capture():

    light.off()
    stamp = datetime.now().isoformat()
    camera.capture('/home/pi/%s.jpg' % stamp)
    sleep(1)
    light.on()


def loop():
    While True:
      right_button.when_pressed = capture()



try:
   loop()
except KeyboardInterrupt:  # When 'Ctrl+C' is pressed, the child program destroy() will be  executed.
   destroy()

I have currently 2 problems with running this code on my Raspberry Pi Zero. The first is that the LED does not light up, despite my efforts to plug in the ends correctly. The second is that once I press the button, the camera keeps taking pictures in an infinite loop onto the folder, until I kill the process. I can provide a picture if needed.

Anyone got any suggestions or tips? If I'm making any really dumb mistakes, I'm really sorry.

Thank you!

Answer 1

Using this:

right_button.when_pressed = capture()

Sets value of right_button.when_pressed equal to what capture RETURNS, which is nothing, when really you want to set it to the function itself

You are continually setting the callback function to be None. And because of this, its just a while loop on capture, which means that the light.on() and the light.off() are only seperated by the time it takes to go around the loop, (instantly basicly) so you are never seeing the light come on. (and it will continue to take pictures)

If right_button.when_pressed is expecting a callback function it would look like this

def loop()
    right_button.when_pressed=capture  #sets the callback function, no "()"
    while True:
        time.sleep(1)   #do nothing in the loop, as the callback function will get called when pressed